Skip to content

test: increase timeout in test_human_readable_logs.py#11972

Merged
borisstoyanov merged 1 commit intoapache:mainfrom
weizhouapache:4.22-fix-test_human_readable_logs
Jan 30, 2026
Merged

test: increase timeout in test_human_readable_logs.py#11972
borisstoyanov merged 1 commit intoapache:mainfrom
weizhouapache:4.22-fix-test_human_readable_logs

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Nov 4, 2025

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Nov 4, 2025
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Nov 4, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 4, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, though a bit of a workaround rather then a definite solution, which is alright for test code.

@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (15c2e50) to head (99672bb).
⚠️ Report is 305 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11972      +/-   ##
============================================
- Coverage     17.56%   17.56%   -0.01%     
- Complexity    15543    15545       +2     
============================================
  Files          5909     5909              
  Lines        529056   529056              
  Branches      64617    64617              
============================================
- Hits          92947    92946       -1     
- Misses       425654   425655       +1     
  Partials      10455    10455
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

blueorangutan commented Nov 4, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15631

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Nov 4, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 4, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 5, 2025

[SF] Trillian test result (tid-14770)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59215 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11972-t14770-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@harikrishna-patnala
Copy link
Contributor

harikrishna-patnala commented Jan 28, 2026

@weizhouapache should we consider this PR and still valid ?

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Jan 28, 2026

@weizhouapache should we consider this PR and still valid ?

ah yes. thanks @harikrishna-patnala for heads-up

@weizhouapache weizhouapache marked this pull request as ready for review January 28, 2026 09:27
borisstoyanov
borisstoyanov approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borisstoyanov borisstoyanov merged commit bb391c3 into apache:main Jan 30, 2026
43 of 44 checks passed
@DaanHoogland DaanHoogland deleted the 4.22-fix-test_human_readable_logs branch January 30, 2026 07:33
@DaanHoogland DaanHoogland added this to the 4.23.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @blueorangutan @harikrishna-patnala @DaanHoogland @borisstoyanov